Commit Graph

3 Commits

Author SHA1 Message Date
null 7ce5fb66f5 refactor(types): type-check server.cts + document the 8 intentional @ts-nocheck files
- server.cts (the app entry): dropped @ts-nocheck, added the leading
  import type + handler/callback annotations (30 mechanical errors).
  types/http.d.ts gained the 2-arg res.redirect(status, url) overload
  (same gap class as the download overload). Verified by a real boot
  smoke: node server.cts → /api/health + /api/version both 200.
- The 8 remaining files (4 db migration/seed factories + 4 dynamic
  parsers/matchers: spreadsheet/userDbImport/subscription/oidc) now carry
  an INTENTIONAL rationale instead of a bare 'TODO: type incrementally' —
  they parse inherently-unknown input or mutate arbitrary historical
  schemas, where full typing yields 'any' anyway or adds risk to
  data-critical boot code. This is the defensible steady state, not debt.

@ts-nocheck server count: 9 -> 8, and QA-B0-04 is now CLOSED: all 29
routes + server.cts checked, 8 documented exceptions. ci green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-11 07:17:55 -05:00
null f587d09d4a style: apply Prettier across client + server (no behavior change)
One-time repo-wide `prettier --write` (isolated commit so future diffs
stay reviewable). Mechanical formatting only.

Verified unchanged: typecheck + typecheck:server + check:server clean;
server tests 232/232; client tests 50/50; Vite build succeeds.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-06 14:23:53 -05:00
null 409b8a5618 refactor(server): finish services layer — subscription/spreadsheet/oidc/userDbImport → .cts
Completes the services/ TypeScript migration (0 .js remain). These four are the
largest, most dynamic modules (subscription-catalog matcher, xlsx/spreadsheet
parser, OIDC protocol client, SQLite user-DB importer); converted to .cts with a
top-of-file @ts-nocheck so they run via Node type-stripping now, with rich typing
deferred as an incremental follow-up. The other ~46 services are fully typed.

Behavior-preserving. Verified: typecheck:server 0, check:server 0, suite 226/226.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-06 11:22:44 -05:00
Renamed from services/subscriptionService.js (Browse further)