The Cisco partner logo is scaled inside overflow-hidden, so the trademark is cropped #239
Labels
No Label
P0
P1
P2
P3
accessibility
backend
bug
content
data-integrity
enhancement
frontend
infra
integration
owner
owner-input
performance
phase-7
phase-8
release-blocker
security
seo
ui
ux
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: null/Queue-North-Website#239
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found at build
a25077d. Live on production since the tiles were built.The Cisco mark ships in a 700x700 canvas it only fills 66% of (artwork bbox 118.6, 142.2, 462.3 x 388.6), so
object-containrendered it visibly smaller than the 8x8 logo beside it. Both pages compensated by scaling it up inside a clipping box:/:p-1 overflow-hiddenwithscale-[1.5]: a 105px image in an 80px container, 13px cut off/about:p-1 overflow-hiddenwithscale-[2]: a 112px image in a 64px container, 24px cut offReported on all ten device profiles, as
clipped(blocking) andmedia_overflow(high).Fix: crop the asset's own
viewBoxto the artwork plus an even margin (82 105 537 463) and drop the scale and the clipping box, so the tile's padding is the clear space. Nothing is scaled, nothing is clipped, and the mark now renders at 62x46 on/, the same size as the 8x8 logo next to it./aboutalso moves fromCisco-Partner-Logo_trasnp_w.pngtocisco-partner-logo-white.svg, which is the same artwork and takes the same crop, so there is one asset to keep correct rather than two. The PNG is left inpublic/unreferenced rather than deleted in a CSS commit.Verify:
node scripts/device-sweep.mjsreports noclippedormedia_overflowfinding on/or/about; restoringscale-[1.5] overflow-hiddenon Home makes it report both again.